Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(experimental): add autoClose when another element is focused, hide actions on non-touch devices #6801

Merged
merged 1 commit into from
Feb 16, 2024
Merged

feat(experimental): add autoClose when another element is focused, hide actions on non-touch devices #6801

merged 1 commit into from
Feb 16, 2024

Conversation

MillerSvt
Copy link
Collaborator

No description provided.

@MillerSvt MillerSvt changed the base branch from main to v3.x February 15, 2024 14:17
@lumberjack-bot lumberjack-bot
Copy link

lumberjack-bot bot commented Feb 16, 2024 •
edited
Loading

Pull request was closed ✔️

All saved screenshots (for current PR) were deleted 🗑️

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 16, 2024 •
edited
Loading

Visit the preview URL for this PR (updated for commit a60ada0):

https://taiga-ui--pr6801-fix-swipe-actions-imqjuvsr.web.app

(expires Sat, 17 Feb 2024 09:46:44 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 4b5ece1e114386f6a105425ef799091475b249eb

@bundlemon BundleMon
Copy link

bundlemon bot commented Feb 16, 2024 •
edited
Loading

BundleMon

Files updated (1)
Status Path Size Limits
✅ demo/browser/main.(hash).js
 384.73KB (+77B +0.02%) +10%
Unchanged files (4)
Status Path Size Limits
✅ demo/browser/vendor.(hash).js
 213.01KB +10%
✅ demo/browser/runtime.(hash).js
 40.65KB +10%
✅ demo/browser/polyfills.(hash).js
 11.25KB +10%
✅ demo/browser/styles.(hash).css
 1.39KB +10%

Total files change +83B +0.01%

Unchanged groups (1)
Status Path Size Limits
✅ demo/browser/*..js
 2.36MB -

Final result: ✅

View report in BundleMon website ➡️

Current branch size history | Target branch size history

@codecov Codecov
Copy link

codecov bot commented Feb 16, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (v3.x@069a650). Click here to learn what that means.

Additional details and impacted files 
@@           Coverage Diff           @@
##             v3.x    #6801   +/-   ##
=======================================
  Coverage        ?   70.51%           
=======================================
  Files           ?     1097           
  Lines           ?    13110           
  Branches        ?     1857           
=======================================
  Hits            ?     9245           
  Misses          ?     3553           
  Partials        ?      312
Flag Coverage Δ
addon-charts 71.46% <ø> (?)
addon-doc 60.58% <ø> (?)
addon-mobile 60.63% <ø> (?)
addon-table 60.75% <ø> (?)
addon-tablebars 96.15% <ø> (?)
cdk ∅ <ø> (?)
core 77.63% <ø> (?)
kit 70.28% <ø> (?)
summary 70.51% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@splincode splincode merged commit 447baca into v3.x Feb 16, 2024
32 of 33 checks passed
@splincode splincode deleted the fix-swipe-actions branch February 16, 2024 10:36
This was referenced Feb 20, 2024
Merged
Merged
@taiga-family-bot taiga-family-bot mentioned this pull request Mar 4, 2024
Merged
@taiga-family-bot taiga-family-bot mentioned this pull request Mar 12, 2024
Merged
This was referenced Mar 19, 2024
Merged
Merged
This was referenced Apr 2, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vladimirpotekhin vladimirpotekhin vladimirpotekhin left review comments

@splincode splincode splincode approved these changes

@waterplea waterplea waterplea approved these changes

@MarsiBarsi MarsiBarsi Awaiting requested review from MarsiBarsi MarsiBarsi is a code owner

@nsbarsukov nsbarsukov Awaiting requested review from nsbarsukov nsbarsukov is a code owner

Assignees
No one assigned
Labels
ready to merge
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@MillerSvt @waterplea @splincode @vladimirpotekhin